Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add NonEmptyChunk.fold #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2020
Merged

add NonEmptyChunk.fold #3687

merged 1 commit into from
May 22, 2020

Conversation

@simpadjo
Copy link
Contributor

and minor improvements in type signatures

@simpadjo simpadjo requested a review from iravid as a code owner May 22, 2020 12:38
@iravid
Copy link
Member

iravid commented May 22, 2020

@adamgfraser can you chime in on the name?

@adamgfraser
Copy link
Contributor

It seems strange. Normally fold would be a method on a data type and here it is not a method on a data type but the data type we are "folding" is Chunk instead of NonEmptyChunk and we are folding over the hypothetical empty and nonempty cases instead of the elements as we normally would for a collection.

Maybe make it a method on Chunk and call it nonEmptyOrElse?

@simpadjo
Copy link
Contributor Author

Agree!

@simpadjo
Copy link
Contributor Author

@adamgfraser @iravid done

iravid
iravid approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Excellent addition @simpadjo.

@iravid iravid merged commit b815df1 into zio:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iravid iravid iravid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simpadjo @iravid @adamgfraser