Add ZStream.fromFile #3697
Merged
Add ZStream.fromFile #3697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dec0fa1 to
7321e27
Compare
simpadjo
reviewed
May 25, 2020
| items <- fiber.join | ||
| } yield assert(items)(equalTo(c.toSeq.toList)) | ||
| }) | ||
| testM("fromFile") { |
There was a problem hiding this comment.
Don't think that these two tests are mutually exclusive :)
| } yield assert(items)(equalTo(c.toSeq.toList)) | ||
| }) | ||
| testM("fromFile") { | ||
| val data = List.fill(76)("a").mkString |
There was a problem hiding this comment.
We are are pulling the same data every time. Since we are dealing with mutable buffers, it makes the test less powerful.
Maybe data = (1 to 100).mkString ?
| }) | ||
| testM("fromFile") { | ||
| val data = List.fill(76)("a").mkString | ||
|
|
There was a problem hiding this comment.
Also would be great to have a negative test. E.g. reading from a missing file
adamgfraser
previously approved these changes
May 25, 2020
7321e27 to
1fcd182
Compare
|
The fromQueue test somehow ended up in the platform-specific file, whereas it exists in the cross-platform tests :-) |
|
LGTM as well |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3646
Just the simple whole-file version currently.