Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@iravid
Copy link
Member

@iravid iravid commented May 30, 2020

Resolves #3729

@iravid iravid force-pushed the fix-intersperse branch from 0926f68 to 939b53a Compare May 30, 2020 17:31
} else {
builder += middle
builder += o
flag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm 🧐 true once, true forever

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that, but it makes sense. You only need to avoid adding middle the first time

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah let me simplify that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding a flag var and changing the foldLeft for a foreach

luis3m
luis3m previously approved these changes May 30, 2020
Copy link
Contributor

@luis3m luis3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iravid iravid merged commit 0c9f6a0 into zio:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZStream#intersperse breaks with usage of Stream.repeatEffect

3 participants