Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement Fast Single Element Prepend for Chunk #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2020
Merged

Implement Fast Single Element Prepend for Chunk #3747

merged 2 commits into from
Jun 3, 2020

Conversation

@adamgfraser
Copy link
Contributor 

[info] Benchmark                             (size)   Mode  Cnt     Score    Error  Units
[info] ChunkPrependBenchmarks.chunkPrepend    10000  thrpt   25  7788.576 ± 35.149  ops/s
[info] ChunkPrependBenchmarks.vectorPrepend   10000  thrpt   25  4383.454 ± 14.474  ops/s

@adamgfraser adamgfraser requested a review from jdegoes June 2, 2020 18:58
@adamgfraser adamgfraser requested a review from iravid as a code owner June 2, 2020 18:58
@iravid
Copy link
Member

iravid commented Jun 2, 2020 •
edited
Loading

Love it! Why the change from + to :+?

@adamgfraser
Copy link
Contributor Author

I thought if we are having +: for prepend then for symmetry we should also have :+ for append. Also, now that Chunk extends IndexedSeq, :+ and +: are already methods brought in from the standard library so seems a little weird to have a different symbolic alias to do the same thing and it is now consistent with other Scala collections.

iravid
iravid previously approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Can we keep the removed methods under a @deprecated annotation to guide people to the right place?

@adamgfraser
Copy link
Contributor Author

Yes. Done now.

@adamgfraser adamgfraser requested a review from iravid June 2, 2020 20:36
@iravid iravid merged commit a3a91fb into zio:master Jun 3, 2020
@adamgfraser adamgfraser deleted the prepend branch June 22, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iravid iravid iravid approved these changes

@jdegoes jdegoes Awaiting requested review from jdegoes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamgfraser @iravid