Thanks to visit codestin.com
Credit goes to github.com

Skip to content

delete Transducer#zip #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2020
Merged

delete Transducer#zip #3742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions streams-tests/shared/src/test/scala/zio/stream/ZTransducerSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package zio.stream

import ZStreamGen._

import zio._
import zio.test.Assertion._
import zio.test._
Expand Down Expand Up @@ -61,21 +59,6 @@ object ZTransducerSpec extends ZIOBaseSpec {
val parser = initErrorParser.mapM[Any, String, String](n => UIO.succeed(n.toString))
assertM(run(parser, List(Chunk(1))).either)(isLeft(equalTo("Ouch")))
} @@ zioTag(errors)
),
suite("zipWith")(
testM("coherence with List#zip") {
val t1: ZTransducer[Any, Nothing, Int, List[Int]] = Transducer.collectAllN(2)
val t2: ZTransducer[Any, Nothing, Int, List[Int]] = Transducer.collectAllN(3)
def f(l: List[Int], r: List[Int]): List[Int] = l ++ r
val t3 = t1.zipWith(t2)(f)
checkM(tinyListOf(Gen.chunkOf(Gen.anyInt))) { chunks =>
for {
lefts <- ZStream.fromChunks(chunks: _*).transduce(t1).runCollect
rights <- ZStream.fromChunks(chunks: _*).transduce(t2).runCollect
zipped <- ZStream.fromChunks(chunks: _*).transduce(t3).runCollect
} yield assert(zipped)(equalTo(lefts.zip(rights).map(e => f(e._1, e._2))))
}
}
)
),
suite("Constructors")(
Expand Down
69 changes: 0 additions & 69 deletions streams/shared/src/main/scala/zio/stream/ZTransducer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,75 +31,6 @@ abstract class ZTransducer[-R, +E, -I, +O](val push: ZManaged[R, Nothing, Option
}
}

/**
* Symbolic alias for [[ZTransducer#zip]].
*/
final def <&>[R1 <: R, E1 >: E, I1 <: I, O2](that: ZTransducer[R1, E1, I1, O2]): ZTransducer[R1, E1, I1, (O, O2)] =
self zip that

/**
* Symbolic alias for [[ZTransducer#zipLeft]].
*/
final def <&[R1 <: R, E1 >: E, I1 <: I, O2](that: ZTransducer[R1, E1, I1, O2]): ZTransducer[R1, E1, I1, O] =
self zipLeft that

/**
* Symbolic alias for [[ZTransducer#zipRight]].
*/
final def &>[R1 <: R, E1 >: E, I1 <: I, O2](that: ZTransducer[R1, E1, I1, O2]): ZTransducer[R1, E1, I1, O2] =
self zipRight that

/**
* Zips this transducer with another point-wise, but keeps only the outputs of this transducer.
*/
def zipLeft[R1 <: R, E1 >: E, I1 <: I, O2](that: ZTransducer[R1, E1, I1, O2]): ZTransducer[R1, E1, I1, O] =
zipWith(that)((o, _) => o)

/**
* Zips this transducer with another point-wise, but keeps only the outputs of the other transducer.
*/
def zipRight[R1 <: R, E1 >: E, I1 <: I, O2](that: ZTransducer[R1, E1, I1, O2]): ZTransducer[R1, E1, I1, O2] =
zipWith(that)((_, o2) => o2)

/**
* Zips this transducer with another point-wise and emits tuples of elements from both transducers.
*/
def zip[R1 <: R, E1 >: E, I1 <: I, O2](that: ZTransducer[R1, E1, I1, O2]): ZTransducer[R1, E1, I1, (O, O2)] =
zipWith(that)((_, _))

/**
* Zips this transducer with another point-wise and applies the function to the paired elements.
*/
def zipWith[R1 <: R, E1 >: E, I1 <: I, O2, O3](
that: ZTransducer[R1, E1, I1, O2]
)(f: (O, O2) => O3): ZTransducer[R1, E1, I1, O3] = {
type State = Either[Chunk[O], Chunk[O2]]
ZTransducer {
for {
ref <- ZRef.make[State](Left(Chunk.empty)).toManaged_
p1 <- self.push
p2 <- that.push
push = (in: Option[Chunk[I1]]) => {
ref.get.flatMap { excess =>
for {
res <- p1(in).zipWithPar(p2(in)) {
case (leftUpd, rightUpd) =>
val (left, right) = excess.fold(l => (l ++ leftUpd, rightUpd), r => (leftUpd, r ++ rightUpd))
stream.internal.Utils.zipChunks(left, right, f)
}
(emit, newExcess) = res
_ <- ref.set(in.fold(Left(Chunk.empty): Either[Chunk[O], Chunk[O2]])(_ => newExcess))
} yield {
emit
}
}
}
} yield {
push
}
}
}

/**
* Compose this transducer with a sink, resulting in a sink that processes elements by piping
* them through this transducer and piping the results into the sink.
Expand Down