Make fromCompletionStage Referentially Transparent #3755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This looks good to me. Interestingly enough the workaround we're using in the meantime is also wrapping the thunk in an effect. I personally like that change too. 👍 |
iravid
approved these changes
Jun 4, 2020
This was referenced Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
fromCompletionStagewas not referentially transparent because we were capturing alazy valnot suspended in an effect. One change in semantics to note. Previously if thethunkthrew an exception that would be translated into aDiefailure. I think since we are returning aTaskwe should translate it into aFailfailure. Let me know what you think.Copying @reibitto.