Optimize TPriorityQueue #3798
Merged
Optimize TPriorityQueue #3798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phderome
reviewed
Jun 12, 2020
| } | ||
| }, | ||
| testM("removeIf") { | ||
| val elems = List(2, 4, 6, 3, 5, 6) |
There was a problem hiding this comment.
you could possibly choose the even numbers out of order here to show evidence that the priority matters (and similarly for odds)
There was a problem hiding this comment.
Changed it to a property based test to cover that.
phderome
reviewed
Jun 12, 2020
| */ | ||
| def takeAll: USTM[List[A]] = | ||
| map.size.flatMap(n => STM.collectAll(STM.replicate(n)(take))) | ||
| ref.modify(map => (map.flatMap { case (k, v) => List.fill(v)(k) }.toList, map.empty)) |
There was a problem hiding this comment.
ha, v is the count reference of how many times k occurs.
|
@phderome Thank you for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.