Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Transducer.collect*N shouldn't emit empty aggregates #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

Transducer.collect*N shouldn't emit empty aggregates #3827

merged 1 commit into from
Jun 17, 2020

Conversation

@simpadjo
Copy link
Contributor

Follow-up for #3819

@iravid is right, we should filter-out empty aggregates at Transducer level.
It's already like that for, e.g. collectAllWhile

@simpadjo simpadjo requested a review from iravid as a code owner June 17, 2020 08:44
@simpadjo simpadjo changed the title Transducer.collect*N shouldn't emit empty chunks Transducer.collect*N shouldn't emit empty aggregates Jun 17, 2020
iravid
iravid approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up @simpadjo

@iravid iravid merged commit 599e3bc into zio:master Jun 17, 2020
@simpadjo simpadjo deleted the tr-collect branch June 17, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iravid iravid iravid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simpadjo @iravid