Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make error parameters by-name #3839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2020
Merged

Make error parameters by-name #3839

merged 3 commits into from
Jul 26, 2020

Conversation

@yoohaemin
Copy link
Contributor

Make error parameters by name if they may not be used.

@yoohaemin yoohaemin requested a review from iravid as a code owner June 20, 2020 08:08
adamgfraser
adamgfraser approved these changes Jun 21, 2020
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adamgfraser
Copy link
Contributor

Can you merge upstream changes?

@adamgfraser adamgfraser merged commit 638f714 into zio:master Jul 26, 2020
@yoohaemin yoohaemin deleted the errors-by-name branch July 27, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iravid iravid Awaiting requested review from iravid

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yoohaemin @adamgfraser