Remove Finalizer when Fibers Terminate #3884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely worth doing RC21-1 with this yeah? |
|
Yes. Have we merged any PRs with binary incompatible changes since RC21? |
|
No, I just went over the changes and they're all binaryu compatible. |
|
Yes. Just did the same. Hopefully this will resolve the issues we have been seeing with flakiness on Scala.js in CI. Let's get this in, see if there are any other outstanding PRs we want to get merged, and then get another release out. |
ghostdogpr
approved these changes
Jun 27, 2020
|
@adamgfraser Awesome work on this! 🙏 🎉 |
This was referenced Jun 29, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After further investigation, it appears that the issue we are having with ZIO Query relates to excessive memory consumption. That is why the performance is so much worse in CI than it is locally and why changing the machine in CI from
mediumtolargehas such a performance impact. It appears that although the finalizers can be garbage collected the fact that we are creating such a large data structure with all of these finalizers (~1M in this case) and then have to copy them to an array and sort them as part of releasing them creates excessive memory pressure.This PR removes the finalizer from the parent scope when the fiber terminates. This seems to dramatically reduce the memory consumption. There may be further optimizations to do to avoid locks but this seems to address the immediate issue.