Integrate ZStream with java.io.Reader #3928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
reviewed
Jul 2, 2020
| /** | ||
| * Creates a stream from [[java.io.Reader]]. | ||
| */ | ||
| def fromReader(reader: => Reader): ZStream[Blocking, IOException, Char] = |
There was a problem hiding this comment.
Ahoy! Let's make this similar to fromInputStream. Important points:
- Chunking: there's a
readvariant that reads into a Char array and you can userepeatEffectOptionChunk - The by-name reader needs to be captured in value (otherwise it gets re-initialized every time)
There was a problem hiding this comment.
Ah, good points. I was overeager to make this super simple :). Updated.
iravid
reviewed
Jul 2, 2020
| e => ZIO.fail(Some(e)), | ||
| r => if (r == -1) ZIO.fail(None) else ZIO.succeed(r.toChar) | ||
| ) | ||
| def fromReader(reader: => Reader, chunkSize: Int = ZStream.DefaultChunkSize): ZStream[Blocking, IOException, Char] = |
There was a problem hiding this comment.
I liked your previous approach with repeatEffectOption better :-) How about:
ZStream.fromEffect(reader).flatMap { capturedReader => ZStream.repeatEffectOptionChunk(...)?
There was a problem hiding this comment.
Haha, merged it, but dropped the exceptions used in first try.
There was a problem hiding this comment.
Btw. should I do the same for fromInputStream?
There was a problem hiding this comment.
Yeah why not. Can you add a few tests for fromReader?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3872