add ZTransducer#iso8859_1 #3920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
reviewed
Jul 2, 2020
| * This transducer uses the String constructor's behavior when handling malformed byte | ||
| * sequences. | ||
| */ | ||
| val iso8859_1: ZTransducer[Any, Nothing, Byte, String] = |
There was a problem hiding this comment.
shall we call it iso8859_1Decode to be aligned with utf8Decode? And allow for a potential encoding transducer in the future.
fsvehla
reviewed
Jul 2, 2020
| */ | ||
| val iso8859_1: ZTransducer[Any, Nothing, Byte, String] = | ||
| ZTransducer.fromPush { | ||
| case Some(is) => ZIO.succeedNow(Chunk.single(new String(is.toArray, "ISO-8859-1"))) |
There was a problem hiding this comment.
Using java.nio.charset.StandardCharsets.ISO_8859_1 might save an allocation here
fsvehla
reviewed
Jul 2, 2020
| * This transducer uses the String constructor's behavior when handling malformed byte | ||
| * sequences. | ||
| */ | ||
| val iso8859_1: ZTransducer[Any, Nothing, Byte, String] = |
There was a problem hiding this comment.
In the JVM the charset is referred to as 'ISO_8859_1', maybe we should add a _ after iso
2ab053c to
bd0c19a
Compare
iravid
approved these changes
Jul 2, 2020
|
Nice work Maxim, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3865