Handle Partial Ordering in TPriorityQueue #3923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phderome
reviewed
Jul 1, 2020
| val genEvents: Gen[Random with Sized, Chunk[Event]] = | ||
| Gen.chunkOf(genEvent) | ||
|
|
||
| val genPredicate: Gen[Random, Event => Boolean] = |
phderome
reviewed
Jul 1, 2020
| */ | ||
| def offer(a: A): USTM[Unit] = | ||
| ref.update(map => map + (a -> map.get(a).fold(1)(_ + 1))) | ||
| ref.update(map => map + (a -> map.get(a).fold(::(a, Nil))(::(a, _)))) |
There was a problem hiding this comment.
we specify all the values at same partial ordering in a non-empty list ( a cons), as opposed to counting how many elements of same partial ordering we have.
phderome
reviewed
Jul 1, 2020
| builder ++= l | ||
| r match { | ||
| case h :: t => updated += (a -> ::(h, t)) | ||
| case Nil => updated -= a |
There was a problem hiding this comment.
this is where we make use of the a: A on left side of SortedMap in TRef[SortedMap[A, ::[A]] by removing the elements at same priority/partial ordering when there is no more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current encoding of
TPriorityQueuerequires theOrderingon elements to be a total ordering. While potentially desirable, sometimes intentionally or unintentionally users can define a partial ordering (e.g. ordering events by timestamp but not defining a further way of ordering events with the same timestamp). This PR updatesTPriorityQueueto correctly handle these situations.Copying @phderome.