Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add ZTranducer#US-ASCII #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2020
Merged

Add ZTranducer#US-ASCII #3947

merged 1 commit into from
Jul 28, 2020

Conversation

@vinhhv
Copy link
Contributor

@vinhhv vinhhv commented Jul 8, 2020

Original issue: #3865

@vinhhv vinhhv requested a review from iravid as a code owner July 8, 2020 06:46
@CLAassistant
Copy link

CLAassistant commented Jul 8, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vinhhv vinhhv force-pushed the ztransducer#US-ASCII branch from d8f7f5f to a1ba28b Compare July 10, 2020 05:30
iravid
iravid reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @vinhhv! One question regarding exceptions when constructing the string.

@iravid
Copy link
Member

iravid commented Jul 28, 2020

@vinhhv Could you resolve the conflicts? Will merge afterwards

@vinhhv vinhhv force-pushed the ztransducer#US-ASCII branch 3 times, most recently from 914bbc4 to 5082586 Compare July 28, 2020 05:03
@vinhhv vinhhv force-pushed the ztransducer#US-ASCII branch from 5082586 to f874b71 Compare July 28, 2020 05:18
@vinhhv
Copy link
Contributor Author

vinhhv commented Jul 28, 2020

@iravid done!

iravid
iravid approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vinhhv!

@iravid iravid merged commit 60ae99d into zio:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iravid iravid iravid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vinhhv @CLAassistant @iravid