Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mgenereu
Copy link
Contributor

Made the java-time shim for ScalaJS always active since the default runtime includes Clock.

Resolves #3139

@mgenereu
Copy link
Contributor Author

Opened this to do the work but I'm still not clear on the "zero dependency" concept and what falls in or out of that requirement.

@mgenereu mgenereu marked this pull request as ready for review July 11, 2020 18:31
@mgenereu mgenereu requested review from mijicd and softinio as code owners July 11, 2020 18:31
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor comment!

adamgfraser
adamgfraser previously approved these changes Jul 14, 2020
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adamgfraser
Copy link
Contributor

Can you fix the compilation issue with the documentation?

@mgenereu
Copy link
Contributor Author

Sorry I didn't comment that I'm going to change the JS example to actually run in the browser per the mdoc example.

@mgenereu mgenereu marked this pull request as draft July 14, 2020 18:05
@mgenereu
Copy link
Contributor Author

I created an example that uses ZIO and ZIO Clock. It runs locally in a demo app but mdoc:js is using a different version of ScalaJS than the ZIO build. I think that's causing the build fail issues. Do you have any SBT experts that can get the code to compile on mdoc?

@mgenereu mgenereu requested a review from adamgfraser July 15, 2020 05:40
@mgenereu
Copy link
Contributor Author

Started a PR to update mdoc to ScalaJS 1.1.1 but the Linker API has changed significantly and I will need additional help from someone familiar with ScalaJS to complete that Pull Request.
scalameta/mdoc#365

@adamgfraser
Copy link
Contributor

Do we think this will be fixed in the short term? Otherwise we could merge without mdoc and do that in a follow up.

@mgenereu mgenereu marked this pull request as ready for review July 16, 2020 20:42
@mgenereu
Copy link
Contributor Author

mgenereu commented Jul 16, 2020

@adamgfraser Since this is my first ZIO program, could you review that you like the actual code in the JavaScript example? I wanted to:

  1. Give a good example of Scala.JS code.
  2. Give a good example of ZIO code.
  3. Use a Clock example since that's what we're enabling.
  4. Use Console to show that it goes to the browser log.
  5. Show it in the website.
    1. This is the magic node reference that mdoc provides.
    2. My local copy had a getElementById assigning node.
    3. This is disabled until PR Activate mdoc on JavaScript. #3974 comes through.

@mgenereu
Copy link
Contributor Author

Do we think this will be fixed in the short term? Otherwise we could merge without mdoc and do that in a follow up.

I broke it out.

Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One minor comment on the example. Can you also merge upstream changes so you pick up the new MiMa checks for CI?

@adamgfraser adamgfraser merged commit c47c524 into zio:master Aug 3, 2020
@mgenereu
Copy link
Contributor Author

mgenereu commented Aug 3, 2020

Sorry @adamgfraser. Ran short on time to finish the clean up. I'm still looking at the mdoc upgrade stuff. Hopefully I'll have more soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scala.js scala-java-time dependency

2 participants