-
Couldn't load subscription status.
- Fork 1.4k
Java Time Dependency for ScalaJS #3958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…untime includes Clock.
|
Opened this to do the work but I'm still not clear on the "zero dependency" concept and what falls in or out of that requirement. |
…e to use newer ZIO API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one minor comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Can you fix the compilation issue with the documentation? |
|
Sorry I didn't comment that I'm going to change the JS example to actually run in the browser per the mdoc example. |
|
I created an example that uses ZIO and ZIO Clock. It runs locally in a demo app but mdoc:js is using a different version of ScalaJS than the ZIO build. I think that's causing the build fail issues. Do you have any SBT experts that can get the code to compile on mdoc? |
|
Started a PR to update mdoc to ScalaJS 1.1.1 but the Linker API has changed significantly and I will need additional help from someone familiar with ScalaJS to complete that Pull Request. |
|
Do we think this will be fixed in the short term? Otherwise we could merge without mdoc and do that in a follow up. |
|
@adamgfraser Since this is my first ZIO program, could you review that you like the actual code in the JavaScript example? I wanted to:
|
I broke it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One minor comment on the example. Can you also merge upstream changes so you pick up the new MiMa checks for CI?
|
Sorry @adamgfraser. Ran short on time to finish the clean up. I'm still looking at the mdoc upgrade stuff. Hopefully I'll have more soon. |
Made the java-time shim for ScalaJS always active since the default runtime includes Clock.
Resolves #3139