Fix: ZStream.repeatEffectWith delays its outputs #3959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svroonland Your solution looks more correct to me! Thanks for opening this. Can you grab the tests from #3891 and add them here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3863
In the current implementation every element is unnecessarily delayed by the updating of the schedule. The new implementation updates the schedule as part of the next pull.
One consequence when using
Schedule.neveris that in the new version, the stream emits at least 1 element, while in the old version it would not, although the effect was evaluated.The new version has the same semantics as
ZIO(..).repeat(schedule), which is to evaluate the effect once and then use the schedule to repeat.