Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chunk.foldWhileM should not advance iterator twice #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2020
Merged

Chunk.foldWhileM should not advance iterator twice #3967

merged 1 commit into from
Jul 14, 2020

Conversation

@YuvalItzchakov
Copy link
Contributor

@YuvalItzchakov YuvalItzchakov commented Jul 14, 2020 •
edited
Loading

Fixes #3968

Small bug in Chunk.foldWhileM iterates the iterable twice while only checking once:

if (iterator.hasNext) {
  val array  = iterator.next()
  val length = array.length
  loop(z, iterator, iterator.next(), 0, length)
} else {
  ZIO.succeedNow(z)
}

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

adamgfraser
adamgfraser approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@adamgfraser adamgfraser merged commit 8551ae7 into zio:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chunk.foldWhileM explodes due to multiple iterations

3 participants

@YuvalItzchakov @CLAassistant @adamgfraser