Prevent Potential Deadlock in ZIO#foreachPar #3970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3940.
The issue is that in our optimized implementation of
foreachPar_we are forking a fiber for each task and waiting for it to signal success or failure. But if an exception is thrown during the construction of the task this logic is never executed so we suspend indefinitely waiting for the signal.This PR addresses by using
effectSuspendTotalto convert thrown exceptions in constructing the task to fiber failures.One slightly unfortunate thing is that now there is a slight asymmetry between
foreachandforeachParin thatZIO.foreach(as)(f).runwill fail with a fiber failure iffthrowsbutZIO.foreachPar(as)(f).run` will return an exit with a die failure..