Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mschuwalow
Copy link
Member

@mschuwalow mschuwalow commented Jul 17, 2020

  • add ZTransducer#prepend
  • adds support for optional byte order mark to ZTransducer#utf8Decode
  • ZTransducer#utf16Decode will now default to big endianness if no byte order mark is detected

@mschuwalow mschuwalow requested a review from iravid as a code owner July 17, 2020 17:52
* Decodes chunks of UTF-16 bytes into strings.
* If no byte order mark is found big-endianness is assumed.
*
* This will fail with an `IllegalArgumentException` if no byte order mark was found and will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is outdated

Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @mschuwalow

}

// handle optional byte order mark
branchAfter(3) { bytes =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant!

@iravid iravid merged commit 07da9e7 into zio:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants