refineToOrDie for ZStream. #3983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also implement ZManaged#refineToOrDie in the same way as for ZIO, for type safety.
iravid
requested changes
Jul 20, 2020
| /** | ||
| * Keeps some of the errors, and terminates the fiber with the rest. | ||
| */ | ||
| def refineToOrDie[E1 <: E: ClassTag](implicit ev: CanFail[E]): ZManaged[R, E1, A] = |
There was a problem hiding this comment.
Can we keep it on the class with implicit evidence? (implicit ev: E <:< Throwable). Better discoverability that way.
| /** | ||
| * Keeps some of the errors, and terminates the fiber with the rest. | ||
| */ | ||
| def refineToOrDie[E1 <: E: ClassTag](implicit ev: CanFail[E]): ZStream[R, E1, A] = |
There was a problem hiding this comment.
Same - can we keep it on the class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
ZStream#refineToOrDie.Also implement
ZManaged#refineToOrDiein the same way as for ZIO, for type safety.