Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Write a test to search expression functions for panics... and fix one #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zix99 merged 2 commits into from
May 9, 2025
Merged

Write a test to search expression functions for panics... and fix one #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3ce3e1
Write a test to search expression functions for panics... and fix one
zix99 May 9, 2025
844dd3f
Better coverage
zix99 May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pkg/expressions/stdlib/funcs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,18 @@ var StandardFunctions = map[string]KeyBuilderFunction{
"sumi": arithmaticHelperi(func(a, b int) int { return a + b }),
"subi": arithmaticHelperi(func(a, b int) int { return a - b }),
"multi": arithmaticHelperi(func(a, b int) int { return a * b }),
"divi": arithmaticHelperi(func(a, b int) int { return a / b }),
"modi": arithmaticHelperi(func(a, b int) int { return a % b }),
"divi": arithmaticHelperi(func(a, b int) int {
if b == 0 {
return math.MaxInt
}
return a / b
}),
"modi": arithmaticHelperi(func(a, b int) int {
if b == 0 {
return 0
}
return a % b
}),
"maxi": arithmaticHelperi(func(a, b int) int {
if a > b {
return a
Expand Down
82 changes: 82 additions & 0 deletions pkg/expressions/stdlib/funcs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
package stdlib

import (
"rare/pkg/expressions"
"testing"

"github.com/stretchr/testify/assert"
)

// Try to input-search for panics or other errors
// Doesn't check for correctness, just tries to break things
func TestAllFuncsNoPanic(t *testing.T) {
// tests numerous combinations to assure code paths work and never panic
if testing.Short() {
t.SkipNow()
}

var argSets = [][]string{
{"0", "5", "10", "20", "30", "40", "50", "60", "70", "100"},
{"50", "40", "30", "20", "10", "0"},
{"a", "b", "c", "d", "e", "f", "g", "h", "i", "j"},
{"", "", "", "", "", "", "", "", "", ""},
}

for name, fn := range StandardFunctions {
t.Run(name, func(t *testing.T) {

// run function with each argset and subset
for _, argSet := range argSets {

literalSet := make([]expressions.KeyBuilderStage, 0, len(argSet))
contextSet := make([]expressions.KeyBuilderStage, 0, len(argSet))

for i, arg := range argSet {
// Compile and execute using a set of literals
literalSet = append(literalSet, literal(arg))

assert.NotPanics(t, func() {
compiledFunc, err := fn(literalSet)

// if compiled, try to invoke
if err == nil {
assert.NotNil(t, compiledFunc)
}

if compiledFunc != nil {
// even if err isn't nil, if it exists
// it should also be runnable
compiledFunc(mockContext())
}
})

// try the same thing, but with contextual inputs
argIdx := i
contextSet = append(contextSet, func(kbc expressions.KeyBuilderContext) string { return kbc.GetMatch(argIdx) })
ctx := &expressions.KeyBuilderContextArray{
Elements: argSet[:i+1],
}

assert.NotPanics(t, func() {
compiledFunc, err := fn(contextSet)

// if compiled, try to invoke
if err == nil {
assert.NotNil(t, compiledFunc)
}

if compiledFunc != nil {
// even if err isn't nil, if it exists
// it should also be runnable
compiledFunc(ctx)
}
})

}
}

})

}

}
Loading