[Snyk] Security upgrade nginx from 1.28.0-alpine to 1.29.2-alpine #28
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-ALPINE321-CURL-13277273 - https://snyk.io/vuln/SNYK-ALPINE321-CURL-13277274 - https://snyk.io/vuln/SNYK-ALPINE321-CURL-13277275 - https://snyk.io/vuln/SNYK-ALPINE321-CURL-13277277 - https://snyk.io/vuln/SNYK-ALPINE321-CURL-13277278
Summary of ChangesHello @zongruxie4, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request from Snyk correctly updates the nginx base image to a newer version to resolve security vulnerabilities. This is a good and necessary change. I have added one suggestion to further enhance the security and reproducibility of your Docker image by pinning the base image version to its immutable digest.
| # Stage 1 : RUN | ||
| #################################################################### | ||
| FROM nginx:1.28.0-alpine | ||
| FROM nginx:1.29.2-alpine |
There was a problem hiding this comment.
For improved security and build reproducibility, it is a best practice to pin Docker base images to their immutable digest (a SHA256 hash) instead of a mutable tag. While the 1.29.2-alpine tag is specific, it can theoretically be updated to point to a different image. Pinning to a digest ensures you are always using the exact same image, protecting against tag hijacking or unexpected updates.
You can obtain the digest for your image after pulling it and then update the FROM instruction. For example:
FROM nginx:1.29.2-alpine@sha256:<sha256-digest-of-the-image>This practice helps guarantee deterministic builds.
Snyk has created this PR to fix 5 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):
turms-admin/DockerfileWe recommend upgrading to
nginx:1.29.2-alpine, as this image has only 0 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.Vulnerabilities that will be fixed with an upgrade:
SNYK-ALPINE321-CURL-13277273
SNYK-ALPINE321-CURL-13277274
SNYK-ALPINE321-CURL-13277275
SNYK-ALPINE321-CURL-13277277
SNYK-ALPINE321-CURL-13277278
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.