[Snyk] Security upgrade glob from 11.0.0 to 11.1.0 #34
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-GLOB-14040952
Summary of ChangesHello @zongruxie4, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automatically updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly upgrades the glob dependency to version 11.1.0 to address a security vulnerability. However, the package-lock.json file has not been updated. I've added a comment with a recommendation to update the lock file to ensure the fix is applied in all environments. Otherwise, the change is correct.
| "eslint-import-resolver-typescript": "^3.7.0", | ||
| "eslint-plugin-import": "^2.31.0", | ||
| "glob": "^11.0.0", | ||
| "glob": "^11.1.0", |
There was a problem hiding this comment.
While this version bump is correct, the package-lock.json file also needs to be updated to reflect this change. Without updating the lock file, environments that use npm ci will continue to install the old, vulnerable version of glob. Please run npm install and commit the updated package-lock.json.
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
turms-client-js/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-GLOB-14040952
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Command Injection