Add new monitor summary widget parameters #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkabrda
requested changes
Jan 15, 2020
board_widgets.go
Outdated
| TitleSize *string `json:"title_size,omitempty"` | ||
| TitleAlign *string `json:"title_align,omitempty"` | ||
| Type *string `json:"type"` | ||
| SummaryType *string `json:"summary_type"` |
There was a problem hiding this comment.
Is this a required property or not? If not (which I assume is the case), it should be marked with omitempty (which is also done is screen_widgets.go in this PR).
There was a problem hiding this comment.
Good catch! I pushed a commit to fix it.
bkabrda
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new, optional parameters for the monitor summary (manage status) widget:
summary_type, andshow_last_triggered: https://docs.datadoghq.com/graphing/widgets/monitor_summary/#api.It also updates the
TestWidgetsintegration test to test them.