Add small fixes #25
Add small fixes #25
Conversation
|
Huh, apparently non-Linux builds failed. It's due to the |
zrax
left a comment
There was a problem hiding this comment.
I haven't finished reviewing this yet... But in the future, please submit separate PRs for each bug fix or feature. It makes it much easier to review and discuss the changes that way.
| case UNUSED_94: | ||
| case UNUSED_9f: | ||
| case UNUSED_a3: | ||
| case UNUSED_f3: |
There was a problem hiding this comment.
The trouble with "supporting" these (and why I didn't do it originally) is that the tile definitions in CC2 are essentially reading "random" data beyond the end of the array, meaning that these behaviors change from one version to another of CC2. You can already see this by checking out older releases of CC2 and observing that tiles beyond Hook load differently than they do in the latest release. If we really want to support extended tiles, we'll need to have some sort of executable version support added as well :/
| if (start + (long)size != stream->tell()) | ||
| throw ccl::FormatError(ccl::RuntimeError::tr("Failed to parse map data")); | ||
| if (start + (long)size < stream->tell()) | ||
| throw ccl::FormatError(ccl::RuntimeError::tr("Failed to parse map data (%1 extra bytes in map data)").arg(start + (long)size - stream->tell())); |
There was a problem hiding this comment.
It would probably be good to break this long line up
Adds multiple small fixes and features which I don't think are too controversial:
0), which is not the case, 4 Patterns (1) is.