fix: incorrect error message in ASTree::BuildFromCode(...)#511
Open
wilson0x4d wants to merge 1 commit intozrax:masterfrom
Open
fix: incorrect error message in ASTree::BuildFromCode(...)#511wilson0x4d wants to merge 1 commit intozrax:masterfrom
ASTree::BuildFromCode(...)#511wilson0x4d wants to merge 1 commit intozrax:masterfrom
Conversation
zrax
reviewed
Aug 13, 2024
* `opcode` was incorrectly clamped causing misleading output. * modified output with additional info about offending bytecode and position so end-user submissions can become more informative. * for `EXTENDED_ARG` bytecode the position will be off by a few bytes, but, at least the bytecode printed will be correct.
Author
|
indeed, i overlooked the the update i've pushed instead relies on i also updated the disasm code with a similar change (to include the offending bytecode in the output.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opcodewas incorrectly clamped causing misleading output.modified output with additional info about offending bytecode and position so end-user submissions can become more informative.