build: adopt Go 1.24 and use tool directives for dev tools #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, config parsing would accept duplicate job names. `zrepl daemon` would later fail to start with a panic. But tools like `zrepl configcheck` would pass. This PR adds a check to ensure job names are unique. Similarly, internal job names were not being rejected by config parsing Move that check to parse-time as well.
Migrate from the old tools.go pattern (with a separate build/ module) to Go 1.24's native tool directive support. Changes: - Update go.mod to Go 1.24.0 with tool directive block - Remove build/go.mod, build/tools.go, and related scripts - Update Makefile to use 'go tool' instead of installed binaries - GOCOVMERGE now uses '$(GO) tool gocovmerge' - lint/format targets use '$(GO) tool golangci-lint/goimports' Note: protoc plugins still require 'go install tool' because protoc doesn't yet support 'go tool' directly. Ref: https://go.dev/doc/modules/managing-dependencies#tools
problame
commented
Jan 20, 2026
Member
Author
problame
left a comment
There was a problem hiding this comment.
go install tool is a workaround because protoc doesn't yet support invoking plugins via go tool directly.
Once protocolbuffers/protobuf#23509 is resolved, we can remove this and rely purely on go tool for all tools.
Track this issue and revisit when protobuf adds support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate from the old
tools.gopattern (with a separatebuild/module) to Go 1.24's nativetooldirective support as explained in https://go.dev/doc/modules/managing-dependencies#toolsChanges
go.modto Go 1.24.0 withtooldirective blockbuild/go.mod,build/tools.go, and related scripts (go_install_tools.bash,go_install_host_tool.source)go toolinstead of installed binaries:GOCOVMERGEnow uses\$(GO) tool gocovmergelinttarget uses\$(GO) tool golangci-lintformattarget uses\$(GO) tool goimportsCaveat
protoc plugins (
protoc-gen-go,protoc-gen-go-grpc) still requirego install toolbecause protoc doesn't yet support invoking tools viago tooldirectly. See review comment for tracking issue.