Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve BlockFetcher retry mechanism & Gas on Stateless Import #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 3, 2025
Merged

Improve BlockFetcher retry mechanism & Gas on Stateless Import #1799

merged 10 commits into from
Oct 3, 2025

Conversation

@lucca30
Copy link
Contributor

@lucca30 lucca30 commented Sep 30, 2025 •
edited
Loading

Description

  • Fixing retry mechanism for "no peers with witness"
  • Including gas on stateless import

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

@lucca30 lucca30 requested review from a team and cffls September 30, 2025 20:58
cffls
cffls reviewed Sep 30, 2025
View reviewed changes
manav2401
manav2401 reviewed Oct 1, 2025
View reviewed changes
@lucca30 lucca30 changed the title Restricting known blocks and witnesses for announcements Increase BlockFetcher tolerance before triggers downloader Oct 1, 2025
@lucca30 lucca30 changed the title Increase BlockFetcher tolerance before triggers downloader Improve BlockFetcher retry mechanism & Gas on Stateless Import Oct 2, 2025
@cffls
Copy link
Contributor

cffls commented Oct 2, 2025

Looks like sometimes stateless nodes will run into panics:

INFO [10-02|02:53:10.316] Whitelisting new milestone from heimdall block=636 hash=e7aded..5a5318
INFO [10-02|02:53:11.937] Whitelisting new milestone from heimdall block=637 hash=fce993..6c7309
INFO [10-02|02:53:14.373] Whitelisting milestone deferred          err="chain out of sync"
ERROR[10-02|02:53:14.378] error handling milestone ws event        err="chain out of sync"
INFO [10-02|02:53:14.524] Whitelisting milestone deferred          err="chain out of sync"
ERROR[10-02|02:53:14.525] error handling milestone ws event        err="chain out of sync"
INFO [10-02|02:53:15.524] Whitelisting milestone deferred          err="chain out of sync"
ERROR[10-02|02:53:15.525] error handling milestone ws event        err="chain out of sync"
INFO [10-02|02:53:15.990] Whitelisting milestone deferred          err="chain out of sync"
ERROR[10-02|02:53:15.992] error handling milestone ws event        err="chain out of sync"
WARN [10-02|02:53:16.177] Network response id collision            have=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e:eth/68:3 want=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e:eth/68:4
ERROR[10-02|02:53:16.177] Error in making wit request              peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e err="shutting down"
ERROR[10-02|02:53:16.177] Error in building witness requests       peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e err="shutting down"
INFO [10-02|02:53:16.177] dispatcher stopped                       peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e
INFO [10-02|02:53:16.177] witness propagator stopped               peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e
ERROR[10-02|02:53:16.177] Error in making wit request              peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e err=disconnected
ERROR[10-02|02:53:16.177] Error in building witness requests       peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e err=disconnected
ERROR[10-02|02:53:16.177] Error in making wit request              peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e err=disconnected
ERROR[10-02|02:53:16.177] Error in building witness requests       peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e peer=366b706a7c72f4893e8a190897538585a02a3f1b1297eb9979ce1b34ff953f1e err=disconnected
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x1dd2cb4]

goroutine 51812 [running]:
github.com/ethereum/go-ethereum/eth/fetcher.(*witnessManager).fetchWitness(0xc0004a5420, {0xc013202c80, 0x40}, {0x7e, 0x6b, 0xc3, 0x3a, 0x51, 0xde, 0xfd, ...}, ...)
	/var/lib/bor/eth/fetcher/witness_manager.go:518 +0x534
created by github.com/ethereum/go-ethereum/eth/fetcher.(*witnessManager).tick in goroutine 187
	/var/lib/bor/eth/fetcher/witness_manager.go:474 +0x120d
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x1dd2cb4]

goroutine 64606 [running]:
github.com/ethereum/go-ethereum/eth/fetcher.(*witnessManager).fetchWitness(0xc0004a5420, {0xc013202c80, 0x40}, {0xeb, 0xfc, 0xc4, 0x8e, 0xa5, 0xe1, 0x96, ...}, ...)
	/var/lib/bor/eth/fetcher/witness_manager.go:518 +0x534
created by github.com/ethereum/go-ethereum/eth/fetcher.(*witnessManager).tick in goroutine 187
	/var/lib/bor/eth/fetcher/witness_manager.go:474 +0x120d
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x1dd2cb4]

goroutine 64605 [running]:
github.com/ethereum/go-ethereum/eth/fetcher.(*witnessManager).fetchWitness(0xc0004a5420, {0xc013202c80, 0x40}, {0xee, 0xb, 0x7, 0x95, 0x10, 0x48, 0x66, ...}, ...)
	/var/lib/bor/eth/fetcher/witness_manager.go:518 +0x534
created by github.com/ethereum/go-ethereum/eth/fetcher.(*witnessManager).tick in goroutine 187
	/var/lib/bor/eth/fetcher/witness_manager.go:474 +0x120d
Child process exited naturally, container-proc-manager exiting

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cffls cffls merged commit ef0ee16 into develop Oct 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manav2401 manav2401 manav2401 left review comments

@pratikspatil024 pratikspatil024 pratikspatil024 approved these changes

@cffls cffls cffls approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lucca30 @cffls @manav2401 @pratikspatil024