Allow customization of the card element #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new trait named 'HasExtraCardAttributes' has been added for the RadioDeck component. This trait allows for the addition of extra attributes to a card element using an array or a closure. Changes have also been made in the radio-deck.blade.php to utilize these extra card attributes.
The trait and associated methods 'HasExtraCardAttributes' have been renamed to 'HasExtraCardsAttributes' to better reflect their purpose. This naming change is propagated throughout the codebase, including the 'RadioDeck' component and the 'radio-deck.blade.php' view file.
|
Hey @OrangeJuiced nice work and I'll gladly accept this PR but before I merge it could you also add in the read me how this pr will be use so that new users will know this feature is existing. Thank you! |
The README.md has been updated to include the use of the 'extraCardsAttributes' property in the instructions for users. This property allows users to add extra class attributes to the card HTML element in the customizable radio deck implementation using TailwindCSS utilities.
|
Done! @199ocero :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7 added support for the customization of the options and descriptions. This PR extends that work by adding support for customization of the parent card element.
An example use case for this additional customization of the cards is to customize the rounding, ring width, etc.