Sanitize child process environment to fix Arch readline symbol error #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
2Pz
commented
Oct 28, 2025
- Strip problematic env vars (LD_LIBRARY_PATH, LD_PRELOAD, QT_PLUGIN_PATH, QT_QPA_PLATFORM_PLUGIN_PATH, PYTHONHOME, PYTHONPATH, PYINSTALLER_BOOTLOADER) from all child process launches.
- Add PlatformUtils.sanitized_env_for_subprocess() and build_qprocess_environment() helpers.
- Apply sanitized env to:
- QProcess in ui/terminal.py and game_page_components/game_launcher.py
- subprocess.Popen in game_launcher and SteamService
- subprocess.run default via CommandRunner.run
- reserve Flatpak host spawning and login-shell behavior on Linux.
- Fixes Arch Linux crash when launching via manager: /usr/bin/bash: symbol lookup error: bssh … undefined symbol: rl_print_keybinding, by aligning launched processes with a clean environment similar to running in a normal terminal.
- Strip problematic env vars (LD_LIBRARY_PATH, LD_PRELOAD, QT_PLUGIN_PATH, QT_QPA_PLATFORM_PLUGIN_PATH, PYTHONHOME, PYTHONPATH, PYINSTALLER_BOOTLOADER) from all child process launches. - Add PlatformUtils.sanitized_env_for_subprocess() and build_qprocess_environment() helpers. - Apply sanitized env to: - QProcess in ui/terminal.py and game_page_components/game_launcher.py - subprocess.Popen in game_launcher and SteamService - subprocess.run default via CommandRunner.run - reserve Flatpak host spawning and login-shell behavior on Linux. - Fixes Arch Linux crash when launching via manager: /usr/bin/bash: symbol lookup error: bssh … undefined symbol: rl_print_keybinding, by aligning launched processes with a clean environment similar to running in a normal terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.