This repository was archived by the owner on Mar 7, 2021. It is now read-only.
Highlight disabled text field if it is not valid #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadymmarkov
commented
Oct 31, 2016
| - (void)updateWithField:(FORMField *)field { | ||
| [super updateWithField:field]; | ||
|
|
||
| [self validate]; |
Collaborator
Author
There was a problem hiding this comment.
Let me know if you guys see any implication of calling validate here. I's done to update isValid property considering the new value whenever the field is changed.
Collaborator
Author
|
I see https://github.com/hyperoslo/Form/pull/549 fixes Travis, so it's better to get it merged before this one I guess. |
Contributor
Contributor
|
Lets try and fix the Travis build :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@3lvis @zenangst
Validation works for disabled fields as well, but they were not highlighted with
invalidColor. This PR aims to fix that.