Add setting to toggle the yank register using the system clipboard#295
Add setting to toggle the yank register using the system clipboard#295
Conversation
71
left a comment
There was a problem hiding this comment.
Thanks! For some reason I thought this was already implemented.
Please change the documentation comment of ClipboardRegister to indicate that it will not map to the system clipboard if useSystemClipboard is false.
|
How do you access the clipboard with this setting? Do you rebind Ctrl-V back to paste in insert mode? I think I'd prefer the default register to be different from the clipboard register. However, that might be more work to implement. Please feel free to merge this PR without resolving these, since I'm asking for additional features that can be worked on by people who need them in separate PRs. |
|
@ilyagr Yep, similarly to VSCodeVim and others, you'd use the built-in commands to manipulate the clipboard. Further settings to assign another register to the clipboard might be interesting, though. Even if we only support |
…a system clipboard register (or null)
4bbf0aa to
2994809
Compare
|
Thanks for the feedback, I've adjusted the setting to be a dropdown so the user can select their own clipboard register. |
71
left a comment
There was a problem hiding this comment.
Thanks! I prefer this approach, even though it's a bit less obvious to implement.
Thank you, I very much appreciate it!
Vim uses |
|
I think I've addressed all the above feedback including adding |
71
left a comment
There was a problem hiding this comment.
Thanks! Sorry for the delay, I've been really busy.
I also have a few more comments, but after this we should be good to go.
71
left a comment
There was a problem hiding this comment.
Some more nitpicks... Hopefully really the last round!
|
Sorry for the delay, this should be good to go now. |
Adds a setting to enable/disable the default yank register (
") from mapping to the system clipboard.Defaults to enabled so there will be no change for existing users.