Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[flake8-bugbear] Avoid adding default initializers to stubs (B006) #10152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
charliermarsh merged 4 commits into from
Feb 28, 2024
Merged

[flake8-bugbear] Avoid adding default initializers to stubs (B006) #10152

charliermarsh merged 4 commits into from
Feb 28, 2024

Conversation

@Philipp-Thiel
Copy link
Contributor

@Philipp-Thiel Philipp-Thiel commented Feb 28, 2024

Summary

Adapts the fix for rule B006 to no longer modify the body of function stubs, while retaining the change in method signature.

Test Plan

The existing tests for B006 were adapted to reflect this change in behavior.

Relevant issue

#10083

Philipp Thiel added 2 commits February 28, 2024 16:18
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

indico/indico (error) 

ruff failed
  Cause: Rule `S410` was removed and cannot be selected.

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

indico/indico (error) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Rule `S410` was removed and cannot be selected.

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 2 project errors)

indico/indico (error) 

ruff failed
  Cause: Rule `S410` was removed and cannot be selected.

openai/openai-cookbook (error) 

warning: Detected debug build without --no-cache.
error: Failed to read examples/How_to_handle_rate_limits.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: trailing comma at line 47 column 4

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 2 project errors)

indico/indico (error) 

ruff format --preview

ruff failed
  Cause: Rule `S410` was removed and cannot be selected.

openai/openai-cookbook (error) 

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to read examples/How_to_handle_rate_limits.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: trailing comma at line 47 column 4

@charliermarsh charliermarsh self-requested a review February 28, 2024 17:39
@charliermarsh charliermarsh self-assigned this Feb 28, 2024
@charliermarsh charliermarsh added the bug Something isn't working label Feb 28, 2024
charliermarsh
charliermarsh approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh enabled auto-merge (squash) February 28, 2024 18:12
@charliermarsh charliermarsh changed the title B006 (unsafe fix) : does not fix function stubs correctly #10083 [flake8-bugbear] Avoid adding default initializers to stubs (B006) Feb 28, 2024
@charliermarsh charliermarsh merged commit 36bc725 into astral-sh:main Feb 28, 2024
@MichaReiser MichaReiser mentioned this pull request Feb 29, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Feb 29, 2024
Merged
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
@Philipp-Thiel @nkxxll
[flake8-bugbear] Avoid adding default initializers to stubs (`B006…
e894cbb 
…`) (astral-sh#10152)

## Summary

Adapts the fix for rule B006 to no longer modify the body of function
stubs, while retaining the change in method signature.

## Test Plan

The existing tests for B006 were adapted to reflect this change in
behavior.

## Relevant issue

astral-sh#10083
@johnslavik johnslavik mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

@charliermarsh charliermarsh

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Philipp-Thiel @charliermarsh