replace Imgur with GitHub Release Assets for screenshot hosting #3573
+129
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes AppImage#3548 ## Problem Imgur API returns "Too Many Requests" errors (code 1025), blocking successfully tested applications from being merged. ## Solution Replace Imgur with GitHub Release Assets: - Screenshots are uploaded to a draft release named 'ci-screenshots' - Inline images displayed in PR comments - Works for PRs from external contributors using workflow_run trigger
Author
|
@probonopd |
Open
- Add step to sanitize screenshot filenames before upload - Remove invalid characters (: * ? < > |) from app names - Fixes error with apps like 'fre:ac' containing colons - Update publish workflow to handle flat file structure
29420f9 to
36d2f39
Compare
AshBuk
commented
Nov 16, 2025
| github.event.workflow_run.conclusion == 'success' && | ||
| github.event.workflow_run.event == 'pull_request' | ||
| github.event.workflow_run.event == 'pull_request' && | ||
| github.repository == 'AppImage/appimage.github.io' |
Author
There was a problem hiding this comment.
This prevents workflow execution in forks - ensures releases and PR comments
are only created in the upstream repository.
AshBuk
commented
Nov 16, 2025
| COUNT=0 | ||
| FALLBACK="run-${{ github.event.workflow_run.id }}" | ||
| for f in out/screenshots-upload/*.png; do | ||
| for f in out/*.png; do |
Author
There was a problem hiding this comment.
screenshots are now extracted directly to out/
(matching the actual artifact structure)
AshBuk
commented
Nov 16, 2025
| - name: Ensure draft release exists | ||
| - name: Ensure release exists (published) | ||
| shell: bash |
Author
There was a problem hiding this comment.
publish release (not draft) so that URLs render as inline images in PR comments, not just clickable links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3548
Problem
Imgur API returns "Too Many Requests" errors (code 1025), blocking successfully tested applications from being merged.
Solution
Replace Imgur with GitHub Release Assets:
Workflow
Security
1. Separation of contexts:
2. Does not execute code from PR in privileged context:
Reference: Keeping your GitHub Actions and workflows secure: Preventing pwn requests