Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@HWALIMLEE
Copy link
Contributor

#️⃣ Issue Number

  • 194

πŸ“ μš”μ•½(Summary)

  • graph_builder λ©”λ‰΄μ—μ„œ preset 섀정이 query_executor 둜 μ „νŒŒλ˜μ§€ μ•ŠλŠ” 문제

πŸ’¬ To Reviewers (선택)

  • execute_query μ‹€ν–‰ν•  λ•Œ graph_config μ„€μ • 값을 κ°€μ Έμ˜¬ 수 μžˆλ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

PR Checklist

  • κ·Έλž˜ν”„ λΉŒλ” λ©”λ‰΄μ—μ„œ ν™•μž₯으둜 선택 ν›„ langgraph μ‹€ν–‰κ²°κ³Όλ₯Ό μ΄λ―Έμ§€λ‘œ μ €μž₯ ν›„ 잘 λ™μž‘ν•˜λŠ” 것을 확인

reference) How to Code Review

  • 따봉(πŸ‘): 리뷰어가 리뷰이의 μ½”λ“œμ—μ„œ 칭찬의 μ˜κ²¬μ„ 남기고 싢을 λ•Œ μ‚¬μš©ν•©λ‹ˆλ‹€.
  • λŠλ‚Œν‘œ(❗): 리뷰어가 λ¦¬λ·°μ΄μ—κ²Œ ν•„μˆ˜μ μœΌλ‘œ μ½”λ“œ μˆ˜μ •μ„ μš”μ²­ν•  λ•Œ μ‚¬μš©ν•©λ‹ˆλ‹€.
  • λ¬ΌμŒν‘œ (❓): 리뷰어가 λ¦¬λ·°μ΄μ—κ²Œ μ˜κ²¬μ„ 물어보고 싢을 λ•Œ μ‚¬μš©ν•©λ‹ˆλ‹€.
  • μ•Œμ•½ (πŸ’Š): 리뷰어가 리뷰이의 μ½”λ“œμ—μ„œ κ°œμ„ λœ 방법을 μ œμ•ˆν•˜μ§€λ§Œ κ·Έκ²ƒμ˜ 반영이 ν•„μˆ˜κΉŒμ§€λŠ” 아닐 λ•Œ μ‚¬μš©ν•©λ‹ˆλ‹€.

@ehddnr301
Copy link
Collaborator

πŸ‘ @HWALIMLEE κΈ°μ—¬ κ°μ‚¬ν•©λ‹ˆλ‹€!

❗❓
image

engine/query_executor.py μ—μ„œ λ””λ²„κΉ…μš© print문을 μ•„λž˜μ™€ 같이 μΆ”κ°€ν•˜κ³  streamlitμ—μ„œ μ‹€ν–‰ν–ˆμ„λ•Œ μˆ˜μ •λ•Œ μ‚¬μš©ν•˜μ‹  λ³€μˆ˜κ°€ μΈμ‹λ˜μ§€ μ•ŠλŠ”κ²ƒ κ°™μŠ΅λ‹ˆλ‹€. (λ³€μˆ˜λͺ…이 λ‹€λ¦…λ‹ˆλ‹€.)

μΆ”κ°€λ‘œ defaultκ°’μœΌλ‘œ λ„£κ²Œλ˜λ©΄ ν•¨μˆ˜ μ •μ˜ μ‹œμ μ— ν‰κ°€λ˜μ–΄μ„œ session_stateκ°€ μ—…λ°μ΄νŠΈ λ˜μ–΄λ„ λ°˜μ˜λ˜μ§€ μ•Šμ„λ“― ν•©λ‹ˆλ‹€.

    print("--------------------------------")
    print(f"use_enriched_graph: {use_enriched_graph}")
    print(st.session_state.get("use_enriched", False))
    print("--------------------------------")
--------------------------------
use_enriched_graph: False
True
--------------------------------

πŸ’Š streamlit의interface/app_pages/lang2sql.pyμ—μ„œ run_lang2sql 을 ν˜ΈμΆœν•˜κ³  μžˆλŠ”λ° μ—¬κΈ°μ„œ νŒŒλΌλ―Έν„°λ₯Ό λ„˜κ²¨μ£Όλ©΄ μ–΄λ–¨κΉŒ μ‹ΆμŠ΅λ‹ˆλ‹€.

❗Black 을 ν†΅ν•΄μ„œ ν¬λ§€νŒ… λΆ€νƒλ“œλ¦½λ‹ˆλ‹€!

πŸ’¬ 리뷰λ₯Ό μœ„ν•΄ μ‚΄ν”Όλ‹€ λ³΄λ‹ˆ μ½”λ“œκ°€ λ³΅μž‘ν•˜κΈ°λŠ” ν•˜λ„€μš”...! λ³€μˆ˜λͺ…도 κ·Έλ ‡κ³  μ •λΉ„μ˜ ν•„μš”μ„±μ„ μ—¬μ „νžˆ λŠλ‚λ‹ˆλ‹€!

@HWALIMLEE
Copy link
Contributor Author

μ•„ μ €κ±Έ μ²΄ν¬ν•˜κ³  λŒλ¦¬λŠ” κ±Έ κΉœλΉ‘ν–ˆκ΅°μš”..!
λ‹€μ‹œ μˆ˜μ •ν•΄μ„œ pr μ˜¬λ¦¬κ² μŠ΅λ‹ˆλ‹€~

Copy link
Contributor

@ParkGyeongTae ParkGyeongTae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@HWALIMLEE HWALIMLEE changed the title graph_config λ³€μˆ˜ κ°’ λ°›μ•„μ˜¬ 수 μžˆλ„λ‘ μˆ˜μ • run_lang2sql λ‹¨μ—μ„œ νŒŒλΌλ―Έν„° λ°›μ•„μ˜¬ 수 μžˆλ„λ‘ μˆ˜μ • Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants