Fix: issue Non-standard redirect handling in _validate_gateway_url for STREAMABLEHTTP transport #1425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TS0713
approved these changes
Nov 13, 2025
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
568e9f1 to
1f50a4d
Compare
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
crivetimihai
approved these changes
Nov 13, 2025
Nayana-R-Gowda
pushed a commit
that referenced
this pull request
Nov 14, 2025
…r STREAMABLEHTTP transport (#1425) * debug Signed-off-by: rakdutta <[email protected]> * redirect -steamblehttp Signed-off-by: rakdutta <[email protected]> * remove addtional line Signed-off-by: rakdutta <[email protected]> * test Signed-off-by: rakdutta <[email protected]> * validate gateway Signed-off-by: rakdutta <[email protected]> * ruff Signed-off-by: rakdutta <[email protected]> * add doctring and doctest in observability.py Signed-off-by: rakdutta <[email protected]> * ruff Signed-off-by: rakdutta <[email protected]> * flake8 Signed-off-by: rakdutta <[email protected]> --------- Signed-off-by: rakdutta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #1280
This pull request enhances the gateway URL validation logic to properly handle HTTP redirects and improves error handling and test coverage for gateway initialization. The changes ensure that only valid HTTP redirects (3xx status codes) are followed during validation, set a sensible redirect limit, and add comprehensive tests for redirect scenarios. Additionally, gateway initialization now raises a clear error when validation fails.
Gateway URL validation improvements
_validate_gateway_urlmethod ingateway_service.pyto usehttpx's built-in redirect handling, following only proper 3xx redirects and enforcing a maximum number of redirects via the newgateway_max_redirectssetting. The method now logs validation details and treats authentication failures (401, 403, 404) as non-usable endpoints. It also clarifies validation forSTREAMABLEHTTPandSSEtransport types.gateway_max_redirectsconfiguration option toconfig.pyto allow customization of the redirect limit.Gateway initialization and error handling
_validate_gateway_urlbefore connecting to aSTREAMABLEHTTPserver, raising aGatewayConnectionErrorif validation fails. This prevents attempts to connect to invalid or unreachable gateways. [1] [2]Testing improvements
test_gateway_validation_redirects.pyto verify correct redirect behavior during gateway validation, including tests for following valid redirects and not treating 200 responses with aLocationheader as redirects._validate_gateway_urland ensure consistent test behavior.