WIP convert to jackson 3 #14259
Open
WIP convert to jackson 3 #14259
+60
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
stack overflow error in jbang wtf? |
* main: change command imports Chore(deps): Bump org.openrewrite.rewrite from 7.19.0 to 7.20.0 (#14266) Chore(deps): Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.17.0 to 3.18.0 (#14265) Chore(deps): Bump com.google.errorprone:error_prone_core in /versions (#14269) Chore(deps): Bump io.github.thibaultmeyer:cuid in /versions (#14268) Chore(deps): Bump org.gradlex:java-module-testing in /build-logic (#14267) Chore(deps): Bump jablib/src/main/resources/csl-styles (#14264) Chore(deps): Bump appleboy/ssh-action from 1.2.2 to 1.2.3 (#14262) Fix: Ctrl+Shift+L now opens terminal in the active library directory (#14256) # Conflicts: # jabsrv/src/main/java/module-info.java # jabsrv/src/main/java/org/jabref/http/server/command/CommandResource.java
3 tasks
Member
Author
|
definitely something with the dep: |
Member
|
I filed jbangdev/jbang#2281 |
* main: Fix calling JBang command (#14282) .jbang scripts should not be included inside themselves (#14278) Fix typos (#14277) Refactor importDatabase for better readability (#14274) fix jbang (#14276) Feat: Add definition links for TeX Files (#14260) Update preventing module commits (#14273) Fix JabKitLuancher Rename packages in jabkit to start with org.jabref.toolkit to avoid split packages between jabkit and jabgui (#14052). (#14271) Add doi-to-bibtex to examples and JabKit (#14244)
Member
Author
|
needs testing with LSP |
* upstream/main: Fix NPE on startup (#14272)
* upstream/main: (30 commits) Chore(deps): Bump io.github.classgraph:classgraph from 4.8.181 to 4.8.184 in /versions (#14304) Chore(deps): Bump com.fasterxml:aalto-xml in /versions (#14311) Chore(deps): Bump commons-io:commons-io in /versions (#14310) Chore(deps): Bump org.apache.maven.plugins:maven-surefire-plugin (#14298) Disable fetcher-gui-test (#14308) Chore(deps): Bump com.dlsc.gemsfx:gemsfx in /versions (#14307) No labels for dependeabot updates Fix fallback window height from 786 to 768 (#14295) Chore(deps): Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (#14306) Chore(deps): Bump org.apache.maven.plugins:maven-compiler-plugin (#14302) Chore(deps): Bump org.apache.maven.plugins:maven-deploy-plugin (#14300) Chore(deps): Bump org.apache.maven.plugins:maven-clean-plugin (#14299) Chore(deps): Bump jablib/src/main/resources/csl-styles (#14296) Chore(deps): Bump com.vanniktech.maven.publish in /jablib (#14303) Chore(deps): Bump org.apache.maven.plugins:maven-project-info-reports-plugin (#14297) Update all dependencies (#14301) Prepare maven3 example project (#14294) Refactor StringUtilTest to use parameterized tests (#14126) Try to fix download of pr_number Fix workflow names ...
Member
|
Now, JBang outputs This is OK, because |
Member
|
JabKitLauncher has a strange error when it is executed... - I am not sure what this is, but I would wait for a merge in main and see what happens... |
koppor
reviewed
Nov 14, 2025
.jbang/JabKitLauncher.java
Outdated
Comment on lines
33
to
36
| //DEPS com.fasterxml.jackson.core:jackson-annotations:2.20 | ||
| //DEPS tools.jackson.core:jackson-core:3.0.2 | ||
| //DEPS tools.jackson.core:jackson-databind:3.0.2 | ||
| //DEPS tools.jackson.dataformat:jackson-dataformat-yaml:3.0.2 |
Member
There was a problem hiding this comment.
Maybe, this can be left out, because it will come in using the jablib SNAPSHOT from maven central.
koppor
reviewed
Nov 14, 2025
| api("org.junit.jupiter:junit-jupiter") | ||
| api("org.junit.platform:junit-platform-launcher") | ||
|
|
||
| api(platform("tools.jackson:jackson-bom:3.0.2")) |
Member
There was a problem hiding this comment.
The version has to go to below to the constraints (doesn't it?)
Member
Author
There was a problem hiding this comment.
I have absolutely no idea, because it's a bom and other boms are declared at the top as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/1083
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)