-
|
I've been struggling with an issue in a project I've been working on, and not quite getting the mpc tool to generate source that respects the uses that values set in the [MessagePackObject]
public struct Reply
{
[Key("status")]
public readonly string Status;
[Key("response")]
public readonly Dictionary<string, object> Response;
[SerializationConstructor]
public Reply(string status, Dictionary<string, object> response)
{
Status = status;
Response = response;
}
}however, in the generated formatter, the span of bytes produces strings based on the property name and not the value in the specified attribute: I'm invoking the the mpc tool via the command line Is there a way to have the codegen use the values in the key attribute? Thank you all in advance Messagepack version: |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 7 replies
-
|
Oh, that's a very interesting report, and your analysis seems spot on. |
Beta Was this translation helpful? Give feedback.
-
|
By all means, if you'd like to send a PR with your existing fix to our I think our minimum unity version requirement comes from either the oldest version of unity supported by its author, or the oldest version that supports source generators. In our upcoming 3.0 beta version, there is no command line tool to generate the source code any more, so you must be on a unity version that includes source generator support if you want AOT generated formatters. |
Beta Was this translation helpful? Give feedback.
-
|
I wrote a test and found this fails on v3 too. I'm working on a fix for v3. That may also be portable to v2... we'll see. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, so my fix was not directly portable to v2. Your PR is still welcome. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks again - I've put up the PR here: #1963 |
Beta Was this translation helpful? Give feedback.
-
|
also for what it's worth, I was able to successfully integrate |
Beta Was this translation helpful? Give feedback.
Thanks again - I've put up the PR here: #1963