Reviewing files that changed from the base of the PR and between bc887df and 82bc403.

• packages/core/image-asset/image-asset-common.ts (1 hunks)
• packages/core/image-asset/index.android.ts (2 hunks)
• packages/core/image-asset/index.d.ts (1 hunks)

packages/core/image-asset/index.android.ts (1)

38-43: optionsCopy can inherit stale string values

Because getRequestedImageSize already parsed the strings, you can simplify:

-const optionsCopy = {
-    ...this.options,
-    width: requestedSize.width,
-    height: requestedSize.height,
-};
+const optionsCopy = {
+    ...this.options,
+    width: requestedSize.width,
+    height: requestedSize.height,
+};

(If you accept the earlier fix to use optionsCopy inside getRequestedImageSize, this stays consistent.)

Reviewing files that changed from the base of the PR and between 82bc403 and 14629ab.

• packages/core/image-asset/image-asset-common.ts (1 hunks)

packages/core/image-asset/image-asset-common.ts (2)

50-50: Good fix: Correctly using the options parameter.

This addresses the critical issue from the previous review where this.options was incorrectly used in a free function. The function now properly uses the options parameter.

---

72-73:

✅ Verification successful

Verify the type casting logic with undefined values.

The logic looks correct, but ensure that the type casting (optionsCopy.width as number) properly handles the case where width/height might be undefined after invalid string parsing.

Run the following script to verify how the fallback logic behaves with undefined values:

---

🏁 Script executed:

#!/bin/bash
# Description: Test the behavior of the logical OR operator with undefined values

# Create a test script to verify the fallback behavior
cat > test_fallback.js << 'EOF'
// Test the fallback logic
const Screen = { mainScreen: { widthPixels: 1080, heightPixels: 1920 } };
const src = { width: 800, height: 600 };

// Test cases
const testCases = [
  { width: undefined, height: undefined },
  { width: 300, height: undefined },
  { width: undefined, height: 400 },
  { width: 300, height: 400 }
];

testCases.forEach((optionsCopy, index) => {
  const reqWidth = (optionsCopy.width) || Math.min(src.width, Screen.mainScreen.widthPixels);
  const reqHeight = (optionsCopy.height) || Math.min(src.height, Screen.mainScreen.heightPixels);
  console.log(`Test ${index + 1}: width=${optionsCopy.width}, height=${optionsCopy.height} -> reqWidth=${reqWidth}, reqHeight=${reqHeight}`);
});
EOF

# Execute the test
node test_fallback.js

Length of output: 297

---

Fallback logic handles undefined width/height correctly

I verified by passing undefined for optionsCopy.width/height that the expressions

const reqWidth  = (optionsCopy.width as number)  || Math.min(src.width,  Screen.mainScreen.widthPixels);
const reqHeight = (optionsCopy.height as number) || Math.min(src.height, Screen.mainScreen.heightPixels);

correctly fall back to Math.min(src.*, Screen.mainScreen.*):

• Test 1 (undefined, undefined) → reqWidth=800, reqHeight=600
• Test 2 (300, undefined) → reqWidth=300, reqHeight=600
• Test 3 (undefined, 400) → reqWidth=800, reqHeight=400
• Test 4 (300, 400) → reqWidth=300, reqHeight=400

No changes are required here.

Reviewing files that changed from the base of the PR and between 14629ab and f2bdff2.

• packages/core/image-asset/image-asset-common.ts (1 hunks)
• packages/core/image-asset/index.android.ts (2 hunks)
• packages/core/image-asset/index.ios.ts (2 hunks)

• packages/core/image-asset/image-asset-common.ts
• packages/core/image-asset/index.android.ts

packages/core/image-asset/index.ios.ts (1)

40-46: Good defensive programming for cross-platform compatibility.

The updated logic properly checks for method existence before calling getWidth() and getHeight() methods, with appropriate fallbacks to property access. This defensive approach ensures compatibility across different native image implementations while maintaining backward compatibility.

The optional chaining (?.) for nativeImage.size?.width and nativeImage.size?.height is also a good safety measure.