feat: akylas core fork integration #10951
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…possible correctly allow layers animation
…possible correctly allow layers animation
it was breaking core xml
* transform now uses CABasicAnanimation to handle 360 rotate correctly * shadows.. animates correcly with the view (was a default curve issue)
* transform now uses CABasicAnanimation to handle 360 rotate correctly * shadows.. animates correcly with the view (was a default curve issue)
# Conflicts: # packages/core/ui/animation/index.ios.ts
* rollback on handling all animations props in one block. It seems to fail in some cases
…eless and impossible to "disable"
…eless and impossible to "disable"
# Conflicts: # packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/Utils.java
…ns if a view is created while in batchUpdate
…w already showing an alert dialog
# Conflicts: # packages/core/CHANGELOG.md # packages/core/package.json
…w already showing an alert dialog
# Conflicts: # .github/workflows/npm_release_core.yml # package.json # packages/core/package.json # packages/webpack5/package.json # yarn.lock
# Conflicts: # apps/automated/nativescript.config.ts # apps/automated/package.json # apps/toolbox/nativescript.config.ts # apps/toolbox/package.json # apps/toolbox/src/pages/box-shadow.ts # nx.json # package-lock.json # package.json # packages/core/application/application-common.ts # packages/core/application/application-interfaces.ts # packages/core/application/application.android.ts # packages/core/application/application.ios.ts # packages/core/application/helpers.android.ts # packages/core/connectivity/index.android.ts # packages/core/core-types/index.ts # packages/core/core-types/validators.ts # packages/core/data/observable/index.ts # packages/core/image-asset/image-asset-common.ts # packages/core/platforms/android/widgets-release.aar # packages/core/references.d.ts # packages/core/tsconfig.lib.json # packages/core/ui/animation/index.d.ts # packages/core/ui/button/index.android.ts # packages/core/ui/core/view/index.android.ts # packages/core/ui/core/view/index.ios.ts # packages/core/ui/core/view/view-common.ts # packages/core/ui/core/view/view-helper/view-helper-common.ts # packages/core/ui/frame/fragment.transitions.android.ts # packages/core/ui/frame/index.android.ts # packages/core/ui/frame/index.ios.ts # packages/core/ui/label/index.android.ts # packages/core/ui/page/index.android.ts # packages/core/ui/scroll-view/index.ios.ts # packages/core/ui/styling/background-common.ts # packages/core/ui/styling/style-properties.ts # packages/core/ui/tab-view/index.ios.ts # packages/core/ui/text-base/index.android.ts # packages/core/ui/text-base/index.d.ts # packages/core/ui/text-base/text-base-common.ts # packages/types-android/src/lib/android/org.nativescript.widgets.d.ts # packages/ui-mobile-base/android/build.gradle # packages/ui-mobile-base/android/gradle/wrapper/gradle-wrapper.properties # packages/ui-mobile-base/android/widgets/build.gradle # packages/ui-mobile-base/android/widgets/src/main/AndroidManifest.xml # packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/BorderDrawable.java # packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/BoxShadowDrawable.java # packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/LayoutBase.java # packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/Utils.java # packages/webpack5/package-lock.json # packages/webpack5/src/transformers/NativeClass/index.ts
# Conflicts: # apps/automated/nativescript.config.ts # apps/automated/package.json # apps/toolbox/nativescript.config.ts # apps/toolbox/package.json # apps/toolbox/src/pages/box-shadow.ts # nx.json # package-lock.json # package.json # packages/core/application/application-common.ts # packages/core/application/application-interfaces.ts # packages/core/application/application.android.ts # packages/core/application/application.ios.ts # packages/core/application/helpers.android.ts # packages/core/connectivity/index.android.ts # packages/core/core-types/index.ts # packages/core/core-types/validators.ts # packages/core/data/observable/index.ts # packages/core/image-asset/image-asset-common.ts # packages/core/platforms/android/widgets-release.aar # packages/core/references.d.ts # packages/core/tsconfig.lib.json # packages/core/ui/animation/index.d.ts # packages/core/ui/button/index.android.ts # packages/core/ui/core/view/index.android.ts # packages/core/ui/core/view/index.ios.ts # packages/core/ui/core/view/view-common.ts # packages/core/ui/core/view/view-helper/view-helper-common.ts # packages/core/ui/frame/fragment.transitions.android.ts # packages/core/ui/frame/index.android.ts # packages/core/ui/frame/index.ios.ts # packages/core/ui/label/index.android.ts # packages/core/ui/page/index.android.ts # packages/core/ui/scroll-view/index.ios.ts # packages/core/ui/styling/background-common.ts # packages/core/ui/styling/style-properties.ts # packages/core/ui/tab-view/index.ios.ts # packages/core/ui/text-base/index.android.ts # packages/core/ui/text-base/index.d.ts # packages/core/ui/text-base/text-base-common.ts # packages/types-android/src/lib/android/org.nativescript.widgets.d.ts # packages/ui-mobile-base/android/build.gradle # packages/ui-mobile-base/android/gradle/wrapper/gradle-wrapper.properties # packages/ui-mobile-base/android/widgets/build.gradle # packages/ui-mobile-base/android/widgets/src/main/AndroidManifest.xml # packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/BorderDrawable.java # packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/BoxShadowDrawable.java # packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/LayoutBase.java # packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/Utils.java # packages/webpack5/package-lock.json # packages/webpack5/src/transformers/NativeClass/index.ts
# Conflicts: # apps/automated/package.json # apps/toolbox/package.json # apps/toolbox/src/pages/box-shadow.ts # nx.json # package-lock.json # package.json # packages/core/application/application-common.ts # packages/core/application/application-interfaces.ts # packages/core/application/application.android.ts # packages/core/application/application.ios.ts # packages/core/application/helpers.android.ts # packages/core/core-types/index.ts # packages/core/image-asset/image-asset-common.ts # packages/core/tsconfig.lib.json # packages/core/ui/animation/index.d.ts # packages/core/ui/core/view/index.android.ts # packages/core/ui/core/view/view-common.ts # packages/core/ui/frame/fragment.transitions.android.ts # packages/core/ui/frame/index.ios.ts # packages/core/ui/page/index.android.ts # packages/core/ui/scroll-view/index.ios.ts # packages/core/ui/styling/background-common.ts # packages/core/ui/styling/style-properties.ts # packages/core/ui/tab-view/index.ios.ts # packages/core/ui/text-base/text-base-common.ts # packages/types-android/src/lib/android/org.nativescript.widgets.d.ts # packages/webpack5/package-lock.json
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many --target=test --configuration=ci --... |
❌ Failed | 3s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-11-15 19:05:25 UTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a huge PR.
many improvements and all in all we should be 99% compatible. A few things might need to be fixed
@NathanWalker if you want to go through with this we have to fix a few circular issues:
i reverted the accessibility refactor
css parsers are now dynamically imported to prevent having them in the bundle if you dont use them
a few other places like that. For example native-helpers.ios.ts now needs Application.getRootView.
We can look at that together