Add search bar to Player List HUD #654
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johni0702
approved these changes
Jan 11, 2022
Member
Johni0702
left a comment
There was a problem hiding this comment.
Looks good. I'll add in the translation when I merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This PR introduces a new search bar to the player list HUD, which can be used to filter through players available in the menu. This is particularly helpful when you have a large number of players and need to quickly find specific users for shots.
The code additions contain a new
GuiTextFieldadded to the top of the main content pane. The GUI-construction logic has been moved to a separate method, which is re-called when the search field changes. I attempted to stay in line with the existing code formatting as much as possible.I have tested these additions on a replay file with ~1,500 players present and it works great. Let me know if you have any revision requests - thanks!
* Also needs a translation - entry for en_US is
replaymod.gui.playeroverview.search=Search Players. Want me to PR to the translations repository as well?