Add .NET10.0 as TFM #3014
Add .NET10.0 as TFM #3014
Conversation
Can not reproduce it locally..
|
|
||
| Assert.Equal(0, count); | ||
| Assert.Equal([], output); | ||
| Assert.Equal(Array.Empty<byte>(), output); |
There was a problem hiding this comment.
We shouldn’t need to do this. Might be something to do with breaking changes re span overloads though.
There was a problem hiding this comment.
Yeah that came from new overloads
src/ImageSharp/ImageSharp.csproj
Outdated
| <When Condition="$(SIXLABORS_TESTING_PREVIEW) == true"> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>net8.0;net9.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks> |
There was a problem hiding this comment.
I would just drop 9. I don’t want to extend build times and use up LFS budgets
|
I got some problems on my machine.. One with libgdiplus and all the tests that use System.Drawing as a reference. The other is a Tiff test. --> #3017 When I use a tolerant comparer the test is green. Now I am only struggling with the FeatureTestRunner. Now going to look into it |
Tried to debug it on my side. On my machine DOTNET_EnableArm64AdvSimd=0 seems to not work. And on CI/CD we have a problem with DisableSSE .... strange... |
|
I made a small repro and created an issue for this in the runtime repo |
@JimBobSquarePants I got an answer there. The grouping changed and you can now only disable groups and not the individual ones.. What is your favorite way to go on with this? Introduce many #if NET10_0_OR_GREATER in the test code. Or disable the groups for net8 and net10? |
No description provided.