Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implemented group sync in for SAML and also changed border weak in default tooljet theme on platform #14574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: lts-3.16
Choose a base branch
from
Open

Implemented group sync in for SAML and also changed border weak in default tooljet theme on platform #14574

wants to merge 10 commits into from
+99 −5

Conversation

@Siddharthpl
Copy link
Collaborator

@Siddharthpl Siddharthpl commented Nov 13, 2025

@bito-code-review
Copy link

bito-code-review bot commented Nov 13, 2025

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

gsmithun4
gsmithun4 requested changes Nov 13, 2025
View reviewed changes
@bito-code-review
Copy link

bito-code-review bot commented Nov 13, 2025

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

Enterprise Edition :
Deployment: https://tooljet-ee-pr-14574.onrender.com
Dashboard: https://dashboard.render.com/web/srv-d4as6iqli9vc73djhttg

@bito-code-review
Copy link

bito-code-review bot commented Nov 13, 2025

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

@nechalmaggon nechalmaggon added the create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile label Nov 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

Enterprise Edition (LTS):
Deployment: https://tooljet-ee-pr-14574.onrender.com
Dashboard: https://dashboard.render.com/web/srv-d4asu48gjchc73f427tg

@github-actions github-actions bot added active-ee-review-app and removed create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile labels Nov 13, 2025
@bito-code-review
Copy link

bito-code-review bot commented Nov 13, 2025

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

@bito-code-review
Copy link

bito-code-review bot commented Nov 14, 2025

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

@bito-code-review
Copy link

bito-code-review bot commented Nov 14, 2025

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

shah21
shah21 requested changes Nov 14, 2025
View reviewed changes
Copy link
Collaborator

@shah21 shah21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor comment @Siddharthpl

server/data-migrations/1762960587101-AddGroupSyncEnabledToSAMLConfigs.ts Outdated
AND NOT (configs::jsonb ? 'groupSyncEnabled');
`);

// Remove legacy snake_case key if exists (optional cleanup)
Copy link
Collaborator

@shah21 shah21 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we have this key (group_sync_enabled) before? If not, we can remove this cleanup code.

@shah21
Copy link
Collaborator

shah21 commented Nov 14, 2025

@Siddharthpl Adding the sub-module PRs in the description would be helpful.

@bito-code-review
Copy link

bito-code-review bot commented Nov 14, 2025

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

@bito-code-review
Copy link

bito-code-review bot commented Nov 14, 2025

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

shah21
shah21 approved these changes Nov 14, 2025
View reviewed changes
Copy link
Collaborator

@shah21 shah21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In case you work on migrations again in upcoming tasks, please note the TODO comment.

server/data-migrations/1762517351039-PopulateOIDCCustomScopes.ts

public async up(queryRunner: QueryRunner): Promise<void> {

let data: any = process.env;
Copy link
Collaborator

@shah21 shah21 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Next time, create a separate reusable function in scripts and reuse in migrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shah21 shah21 shah21 approved these changes

@johnsoncherian johnsoncherian Awaiting requested review from johnsoncherian johnsoncherian is a code owner

@kavinvenkatachalam kavinvenkatachalam Awaiting requested review from kavinvenkatachalam kavinvenkatachalam is a code owner

@akshaysasidrn akshaysasidrn Awaiting requested review from akshaysasidrn akshaysasidrn is a code owner

@gsmithun4 gsmithun4 Awaiting requested review from gsmithun4 gsmithun4 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

suspend-ee-review-app

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Siddharthpl @shah21 @gsmithun4 @adishM98 @nechalmaggon