-
Notifications
You must be signed in to change notification settings - Fork 19
feat(sdk): implement SDK orchestrator service enhancements #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
160e2c5 to
1857837
Compare
444654b to
f10c43d
Compare
f10c43d to
5da6b53
Compare
| MAX_PAGES = 10 | ||
| skip = 0 | ||
| top = 50 | ||
| pages_fetched = 0 | ||
|
|
||
| while True: | ||
| while pages_fetched < MAX_PAGES: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point of the autopaging up to 10?
| scoped: Literal["org", "tenant"] = "tenant", | ||
| **kwargs: Any, | ||
| ) -> Response: | ||
| import asyncio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already difficult to review a 7500 lines PR. Adding this kind of (technically valid) weirdness makes me trust the AI-generated code even less. Could you please do a pass on the code and break the PR in more manageable pieces?
Implement comprehensive SDK service standardization across 5 core Orchestrator
services
AssetsService:
- Add list() iterator with OData support and auto-pagination
- Add exists() boolean check for asset existence
- Add get_value() convenience method
- Add delete() for asset removal
- Add async variants for all new methods
- Fix retrieve() to raise LookupError when not found
FolderService:
- Add list() iterator with OData filtering
- Add retrieve() with dual-mode lookup (display_name or key)
- Add retrieve_by_path() for path-based lookup
- Add exists() and exists_async() checks
- Add create() and delete() folder operations
- Full async/sync parity across all methods
JobsService:
- Add list() iterator for job enumeration
- Add retrieve() by job_key or job_id
- Add exists() check for job existence
- Add stop(), suspend(), resume() control operations
- Full async variants for all operations
ProcessesService:
- Add list() iterator for process/release enumeration
- Add retrieve() by key or process_id
- Add exists() check for process existence
- Add invoke() convenience wrapper
- Full async/sync parity
QueuesService (Two-Level Architecture):
Queue Definitions:
- Add list_definitions() iterator with OData support
- Add retrieve_definition() by name or key
- Add create_definition() for queue creation
- Add delete_definition() for cleanup
- Add exists_definition() check
Queue Items:
- Add create_item() for adding queue items
- Add list_items() iterator with status filtering
- Full async variants for all operations
5da6b53 to
4ef740d
Compare
Implement comprehensive SDK service standardization across 5 core Orchestrator services
(to fill in a feature gap required for more complete CLI)
AssetsService:
- Add list() iterator with OData support and auto-pagination
- Add exists() boolean check for asset existence
- Add get_value() convenience method
- Add delete() for asset removal
- Add async variants for all new methods
- Fix retrieve() to raise LookupError when not found
FolderService:
- Add list() iterator with OData filtering
- Add retrieve() with dual-mode lookup (display_name or key)
- Add retrieve_by_path() for path-based lookup
- Add exists() and exists_async() checks
- Add create() and delete() folder operations
- Full async/sync parity across all methods
JobsService:
- Add list() iterator for job enumeration
- Add retrieve() by job_key or job_id
- Add exists() check for job existence
- Add stop(), suspend(), resume() control operations
- Full async variants for all operations
ProcessesService:
- Add list() iterator for process/release enumeration
- Add retrieve() by key or process_id
- Add exists() check for process existence
- Add invoke() convenience wrapper
- Full async/sync parity
QueuesService (Two-Level Architecture):
Queue Definitions:
- Add list_definitions() iterator with OData support
- Add retrieve_definition() by name or key
- Add create_definition() for queue creation
- Add delete_definition() for cleanup
- Add exists_definition() check
Queue Items:
- Add create_item() for adding queue items
- Add list_items() iterator with status filtering
- Full async variants for all operations