feat(buckets): add pagination limits to prevent performance issues #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
uipreliga
commented
Nov 11, 2025
- Add PaginationLimitError exception class with unified create() factory method
- Add _MAX_AUTO_PAGINATION_PAGES=10 class constant
- Add pagination limits to all auto-paginating methods:
- list() and list_async() - offset-based (100/50 items per page)
- list_files() and list_files_async() - token-based (500 items per page)
- get_files() and get_files_async() - glob pattern-based (500 items per page)
- Provide context-aware error messages with conditional filter guidance
- Add comprehensive test coverage (14 tests) for all edge cases
411919f to
a4b9a97
Compare
a4b9a97 to
4ef1140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.