Big refactoring #627
Open
Big refactoring #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: CmisSync.Lib/Cmis/PermissionDeniedException.cs CmisSync.Lib/CmisSync.Lib.csproj CmisSync.Lib/Sync/SynchronizedFolder.cs CmisSync/ControllerBase.cs CmisSync/Mac/CmisTree/CmisTreeDataSource.cs CmisSync/Windows/CmisSync.csproj
Conflicts: CmisSync.Lib/Sync/CrawlStrategy.cs CmisSync.Lib/Sync/SynchronizedFolder.cs CmisSync.Lib/Sync/WatcherStrategy.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As i told you some time ago: i was working on a complete refactoring of the code.
The start point was to introduce the Account->SyncedFolder relation, in order to be able to not duplicate the user credentials/change the password only once
But working on this i've also rewritten the GUI using WPF. I'm aware that it's Windows only, but i did not find a viable alternative. (after all i don't think that window and linux/mac should use the same GUI)
I fixed anything i've come across, refactoring it to be more object oriented (in my opinion, but i might be wrong, don't take this as a criticism)
It still need some polish and i've dropped some features (to speed up the work, but i need to readd them):
But the core seem to work nicely.
I hope you'll take a look, and if your interested we can work on it