fix(devtools): forward Angular detection to background #65210
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the content script forwards Angular detection results to the service worker so the popup/icon reflects the page state.
d7ac6f8 to
7f7ee70
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the content script forwards Angular detection results to the service worker so the popup/icon reflects the page state.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Angular DevTools toolbar icon does not turn red when used on a fresh Angular template app and reports no Angular app present. The Angular Devtools panel itself seems to work however.
Issue Number: #65081
What is the new behavior?
Toolbar icon now turns red when used on a fresh Angular template.
Does this PR introduce a breaking change?
Other information
Closes #65081