fix(compiler): throw on invalid in expressions
#65249
Draft
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`{{in}}` are not interpreted as `'in'` string expressions anymore.
fixes angular#65244
JoostK
reviewed
Nov 17, 2025
| this.advance(); | ||
| return new LiteralPrimitive(this.span(start), this.sourceSpan(start), false); | ||
| } else if (this.next.isKeywordIn()) { | ||
| } else if (this.next.isKeywordIn() && this.index > 0) { |
Member
There was a problem hiding this comment.
I don't follow the rationale here, nor for the original code; why would in be tokenized as keyword, yet interpreted as string... string literals should be tokenized as-is, so keyword tokens shouldn't be parsed to string literals.
Making this conditional on token index makes this even weirder. Concretely, I don't expect multi-statement bindings in outputs to be handled correctly:
<a (click)="in; in"></a>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{in}}are not interpreted as'in'string expressions anymore.fixes #65244