Fix a race when collecting list ongoing transactions. #22042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e19ad4c to
40ffb39
Compare
Simran-B
reviewed
Oct 16, 2025
Contributor
There was a problem hiding this comment.
Merge error and there is no code change in the PR anymore?
Contributor
Author
There was a problem hiding this comment.
@Simran-B Unfortunately this fix attempt is invalid and I need to find a different solution, but still need more time for it. That's why I converted this PR to a draft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
The GET /_api/transaction API was missing a lock which could lead to undefined behavior if a transaction would update its state at the same time while we are collecting its details.
Checklist
Tests
I was thinking about adding a regression test, but it is only a small change and designing a test for this specific issue would have been very akward because we need to jump through a lot of hoops to artifically construct the relevant situation.
📖 CHANGELOG entry made