[Supervised AqlValue] ObjectFunctions return supervised AqlValue #22091
Conversation
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 28
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| AqlValue functions::Unset(ExpressionContext* expressionContext, AstNode const&, | ||
| VPackFunctionParametersView parameters) { | ||
| auto* fixedCtx = dynamic_cast<FixedVarExpressionContext*>(expressionContext); | ||
| ResourceMonitor* rm = fixedCtx ? &fixedCtx->resourceMonitor() : nullptr; |
There was a problem hiding this comment.
Bug: Type Confusion Hides Resource Monitor
Inconsistent expression context casting across functions causes ResourceMonitor to be nullptr in many cases. Some functions cast to FixedVarExpressionContext* while others cast to ExecutorExpressionContext*, but both types can be passed. Since both inherit from QueryExpressionContext which provides resourceMonitor(), the cast is unnecessary and causes the resource monitor to be lost when the wrong type is assumed. This defeats the purpose of supervised AqlValue returns.
Scope & Purpose
All the functions in
ObjectFunctions.cppshould return supervised AqlValue.All the functions take ExpressionContext, which is either of 'ExecutorExpressionContext' or 'FixedVarExpressionContext'.
Takes ResourceMonitor from ExpressionContext, and pass it the AqlValue ctor.
💩 Bugfix
🍕 New feature
🔥 Performance improvement
🔨 Refactoring/simplification
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)
Note
ObjectFunctions now return supervised AqlValue, wiring ResourceMonitor from ExpressionContext and using SupervisedBuffer-backed builders where available.
ResourceMonitorfromExecutorExpressionContext/FixedVarExpressionContextand pass toAqlValueconstructors.velocypack::SupervisedBufferfor builders when a monitor is present.MERGE(_RECURSIVE),UNSET(_RECURSIVE),KEEP(_RECURSIVE),TRANSLATE,ATTRIBUTES,VALUES,Value,ZIP, andENTRIES.Aql/FixedVarExpressionContext.h; minor include cleanup.Written by Cursor Bugbot for commit a914bb2. This will update automatically on new commits. Configure here.